Skip to content

Reckless: Add an update command #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

endothermicdev
Copy link
Collaborator

@endothermicdev endothermicdev commented May 5, 2025

Important

25.05 FREEZE MAY 05TH: Non-bugfix PRs not ready by this date will wait for 25.08.

RC1 is scheduled on May 12th, RC2 on May 16th, ...

The final release is on MAY 20TH.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

Adds the ability to update all reckless-installed plugins, or a single one at a time. For repository sources, reckless avoids unnecessarily updating if the latest commit has not advanced from the installed version. The installed version and source are obtained from the .metadata file of the installed plugin.

Sorry, something went wrong.

@endothermicdev endothermicdev added this to the v25.05 milestone May 5, 2025
@endothermicdev endothermicdev force-pushed the reckless_update_command branch 2 times, most recently from 31e3fc2 to c82d5ba Compare May 12, 2025 23:49
This could previously copy the parent directory of a plugin
into the installed reckless directory, which was unnecessary.
This allows installing a local plugin directly without having
to modify reckless sources.

Changelog-changed: Reckless can be passed a local file or directory for installation.
@endothermicdev endothermicdev force-pushed the reckless_update_command branch from c82d5ba to 4393732 Compare May 13, 2025 19:22
remove the duplicative search and extract the enable portion for use next.
This updates all reckless-installed plugins with `reckless update` or
update individual plugins by passing the plugin names as arguments.

The metadata stored with the installed plugin is used to find the
plugin from the appropriate source (the same source is used as when
originally installed.)

Changelog-Added: Reckless: `reckless update` updates all reckless-installed plugins.
@endothermicdev endothermicdev force-pushed the reckless_update_command branch from 4393732 to ad744d1 Compare May 13, 2025 19:32
@endothermicdev
Copy link
Collaborator Author

Rebased and documentation added now that #8261 is merged.

Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack ad744d1

@rustyrussell rustyrussell merged commit 70fa1a4 into ElementsProject:master May 14, 2025
40 checks passed
@endothermicdev endothermicdev mentioned this pull request May 15, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants